[tor-bugs] #14222 [Tor]: rend_cache_entry_t->received is never used; remove/

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#14222: rend_cache_entry_t->received is never used; remove/
------------------------------+------------------------------
 Reporter:  arma              |          Owner:
     Type:  defect            |         Status:  new
 Priority:  normal            |      Milestone:  Tor: 0.2.???
Component:  Tor               |        Version:
 Keywords:  SponsorR, tor-hs  |  Actual Points:
Parent ID:                    |         Points:
------------------------------+------------------------------
 {{{
 diff --git a/src/or/or.h b/src/or/or.h
 index 8a15529..5ecd5f3 100644
 --- a/src/or/or.h
 +++ b/src/or/or.h
 @@ -4962,7 +4962,6 @@ typedef struct rend_service_descriptor_t {
  /** A cached rendezvous descriptor. */
  typedef struct rend_cache_entry_t {
    size_t len; /**< Length of <b>desc</b> */
 -  time_t received; /**< When was the descriptor received? */
    time_t last_served; /**< When did we last write this one to somebody?
                         * (HSDir only) */
    char *desc; /**< Service descriptor */
 diff --git a/src/or/rendcommon.c b/src/or/rendcommon.c
 index 88d9aab..f83d9d5 100644
 --- a/src/or/rendcommon.c
 +++ b/src/or/rendcommon.c
 @@ -1058,7 +1058,6 @@ rend_cache_store_v2_desc_as_dir(const char *desc)
      if (e && !strcmp(desc, e->desc)) {
        log_info(LD_REND, "We already have this service descriptor with
 desc "
                          "ID %s.", safe_str(desc_id_base32));
 -      e->received = time(NULL);
        goto skip;
      }
      /* Store received descriptor. */
 @@ -1075,7 +1074,6 @@ rend_cache_store_v2_desc_as_dir(const char *desc)
        rend_service_descriptor_free(e->parsed);
        tor_free(e->desc);
      }
 -    e->received = time(NULL);
      e->parsed = parsed;
      e->desc = tor_strndup(current_desc, encoded_size);
      e->len = encoded_size;
 @@ -1261,7 +1259,6 @@ rend_cache_store_v2_desc_as_client(const char *desc,
    if (e && !strcmp(desc, e->desc)) {
      log_info(LD_REND,"We already have this service descriptor %s.",
               safe_str_client(service_id));
 -    e->received = time(NULL);
      goto okay;
    }
    if (!e) {
 @@ -1272,7 +1269,6 @@ rend_cache_store_v2_desc_as_client(const char *desc,
      rend_service_descriptor_free(e->parsed);
      tor_free(e->desc);
    }
 -  e->received = time(NULL);
    e->parsed = parsed;
    e->desc = tor_malloc_zero(encoded_size + 1);
    strlcpy(e->desc, desc, encoded_size + 1);
 }}}

 The field of the struct is written to but never used. Did we have a plan
 for it? Or should we simplify and get rid of it?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14222>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs