[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14135 [meek]: Incorrect SocksListener temporary error check

#14135: Incorrect SocksListener temporary error check
------------------------+-----------------
     Reporter:  adam-p  |      Owner:  dcf
         Type:  defect  |     Status:  new
     Priority:  minor   |  Milestone:
    Component:  meek    |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+-----------------

Comment (by adam-p):

 I see what you're saying, and I see that my original suggestion was
 insufficient.

 I ended up implementing your "second thing" -- creating a temporary
 net.Error. Except... it's part of a larger Psiphon change... we needed
 both the original SOCKS4 support and the new SOCKS5 support that's in a
 goptlib branch, so I combined them (including their tests) in such a way
 that it'll branch on the SOCKS version byte sent by the client. You can
 see the changes here:

 https://github.com/Psiphon-Inc/goptlib/pull/1

 You'll see `newTemporaryNetError(...)` returned all over.

 So... I could copy that change over to the Tor goptlib code base. Or...
 maybe you'd be interested in the whole PR I linked to? Is there any use to
 Tor+PT in simultaneously supporting SOCKS4+4a+5?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14135#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs