[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9969 [Tor]: We launch 50 microdesc requests, spread out over just three guards?

#9969: We launch 50 microdesc requests, spread out over just three guards?
------------------------+-------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client, nickm-patch
Actual Points:          |  Parent ID:
       Points:          |
------------------------+-------------------------------------
Changes (by andrea):

 * keywords:  tor-client, nickm-patch, andrea-review => tor-client, nickm-
     patch


Comment:

 2e168566654957cb708d7484c28778e110384ae4:
  - Simple typo fix; looks fine

 c00b397992edefb4507f2c1408e289243f5c7916:
  - This one looks good to me

 f591a4d94cfa6a8ad17fd126e9736196b10a266a:
  - This looks good to me

 f752093e16a8a492f2b9b14255211f68548dc060:
  - This seems okay

 29f15a97edb05d175b97154e0b1c96fd04485ee2:
  - Hmm, we use if (busy) and infer that "the reason that we got no server
    is that servers are busy", but what if
 router_pick_directory_server_impl()
    only skipped some possible servers for being busy?  Are there other
 reasons
    it might fail while having seen some busy servers along the way, and
 should
    the non-zero busy count take precedence in that case?

 21d5dbd474d5dad10a2bfa800df078f7fdc8c40b:
  - I think this looks okay given subsequent fixes

 5ed5ac185bf6f30438af1638f30e04418ed27aff:
  - This looks good to me.

 bb137e23c1c30f7e9f469d4924bbce2bb9b2d2ed:
  - This looks fine

 cae0e7b06bcb75494f75cb29fc0f9a356c284bf4:
  - Looks fine

 06bda506003826bf9a28aec3afe0b7b1ae6cc9c0:
  - Looks fine

 02464694b2fa901e04b8a8f1c467a0773e6d4c27:
  - Yay standards compliance! :)

 482e3cfa0969775233d3f903639c44f32ddaf820:
  - Looks fine to me

 55b21b366c4a8c237dda0a967c0c499e18fb0b4c:
  - Good catch; I think this is different from that potential issue I
 mentioned
    for 29f15a97edb05d175b97154e0b1c96fd04485ee2.

 0fdfdae7e3a88a9172a51f36ac6b536b5687d401:
  - This looks fine

 055ad9c5fb0de4295ccb05357d6a2d8ad29d03e4:
  - Looks okay to me

 6523eff9b3b5e06521da010e238b4cd23ed24e82:
  - Looks okay to me

 fa80983e52cd5213ca2019024eafdc846a720f99:
  - Looks okay to me

 ac9b0a3110ea4eea63133c6d2e3572b2cfd22bd6:
  - This looks okay, but why 500 vs. 1000?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9969#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs