[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9701 [Tor Browser]: Prevent TorBrowser from creating clipboardcache turds

#9701: Prevent TorBrowser from creating clipboardcache turds
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  cypherpunks            |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-disk-leak, interview, tbb-
  Browser                |  firefox-patch, TorBrowserTeam201501R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mcs):

 The revised patch looks OK.  My only nit is to avoid checks like boolVar
 == false.  Please change the line that uses that kind of test to:

   if ((aDataLen > kLargeDatasetSize) && !aIsPrivBrowsing) {

 (I think a simple ! test is more consistent with code elsewhere in
 nsTransferable.cpp and with other Mozilla code).

 Have you tested the fix?  I am not sure how difficult it would be to add
 automated tests to ensure that the fix does not break in the future, but
 Mozilla will want them.  That could be addressed in a separate bug though.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9701#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs