[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14259 [Tor]: memleak in connection_ap_handshake_rewrite_and_attach()

#14259: memleak in connection_ap_handshake_rewrite_and_attach()
------------------------+--------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client
Actual Points:          |  Parent ID:  #7555
       Points:          |
------------------------+--------------------------------

Comment (by asn):

 Looks good to me.

 Maybe a better alternative would have been to never `tor_strdup()` that
 string at all, and just pass `socks->address` directly?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14259#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs