[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13339 [Tor]: Merge GSoC project - Consensus Diffs

#13339: Merge GSoC project - Consensus Diffs
-----------------------------+-------------------------------------------
     Reporter:  mvdan        |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  major        |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  gsoc merge tor-client prop140
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------------------

Comment (by mvdan):

 Okay, I just realised that nickm already did the test fixing, and in a
 slightly different way. So I cherry picked his fixes into consdiff-6 and
 then applied some check-spaces fixes on top.

 I have now compiled a TODO list from all of your comments. I'll work
 through them, not sure how long it will take me but it will be a few days
 at least.

 Quick question for dgoulet:

 * I think the usage of 'len' in smartlist_slice is correct. It means the
 length of the slice. It's similar to how slices in Go are defined (in fact
 I based my struct definition on that). What if I just improved the
 comments a bit?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13339#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs