Re: [tor-bugs] #13339 [Tor]: Merge GSoC project - Consensus Diffs

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#13339: Merge GSoC project - Consensus Diffs
-----------------------------+-------------------------------------------
     Reporter:  mvdan        |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  major        |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  gsoc merge tor-client prop140
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------------------

Comment (by nickm):

 Replying to [comment:16 mvdan]:
 > Some more questions:
 >
 > Nick, you said:
 >
 > > current_{ns,md}_consensus_mmap needs to get passed to tor_munmap if
 it's set before we mmap a new one.
 >
 > Am I not running tor_munmap already?

 I think that you're calling tor_munmap on shutdown, but you might not be
 calling it on reload.

 > > dir_fps might need a better name now.
 >
 > This name was already introduced when I started my gsoc, so I'm not sure
 where it originates from.

 Right; this isn't something you need to fix yourself.

 > I'll keep on working on the suggestions that I can get done on my own,
 about two thirds are already done. It would be great if I could have code
 reviews for consdiff.c as well as pointers for the dirserv.c
 add_cons_diff_bytes_to_outbuf as agreed :)

 I'll try!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13339#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs