[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10395 [Tor]: Tor's consensus lists Torbrowser updates

#10395: Tor's consensus lists Torbrowser updates
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  StrangeCharm           |     Status:  needs_review
         Type:           |  Milestone:  Tor: 0.2.6.x-final
  enhancement            |    Version:
     Priority:  major    |   Keywords:  pantheon chronos prop227 nickm-
    Component:  Tor      |  patch
   Resolution:           |  Parent ID:  #10393
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mcs):

 Replying to [comment:12 nickm]:
 > You are right; it appears I forgot to push it.  I pushed the thing on my
 desktop named "prop227_v2".  Hope it was right.  So sorry :(

 No problem.  Thanks for your work on this feature.  Kathy and I reviewed
 the prop227_v2 code as best we could (we are not very familiar with the
 tor code, so we may have overlooked something).  It looks good to us.  We
 have just a couple of minor comments:

 - There is a typo in the comment just before
 validate_recommended_package_line (recommened_packages should be
 recommended_packages).  Actually, it might be better to replace that with
 RecommendedPackages to match the torrc option.  Also, unless it is not
 your practice to do so, it would be helpful to include a comment there
 that defines the grammar for the line.

 - In or.h, replace "pacakges" with "packages" in a comment.

 We also have a couple of comments on Proposal 227 itself:

 - The consensus method, currently listed as (TBD), can be filled in with
 19.

 - There is no definition for DIGESTTYPE.  Or is that defined in another
 spec.?  We are assuming that it has the same definition as DIGESTVAL.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10395#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs