[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7419 [Tor]: Choose a faster memwipe implementation
#7419: Choose a faster memwipe implementation
-------------------------+------------------------------------
Reporter: nickm | Owner:
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.2.8.x-final
Component: Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-relay | Actual Points:
Parent ID: | Points:
Sponsor: |
-------------------------+------------------------------------
Changes (by teor):
* keywords: tor-relay, nickm-patch => tor-relay
* status: needs_revision => needs_review
Comment:
Replying to [comment:26 selven@â]:
> for the above diff
[https://trac.torproject.org/projects/tor/attachment/ticket/7419/memset_s_explicit_bzero.diff]
, i forgot to add a description
Thanks for the patch and the testing!
It's a straightforward patch that works on later versions of OpenBSD,
NetBSD, and OS X.
(Using memset_s(..., ..., 0, ...) then memset(..., ..., byte, ...) is
redundant, but I'm ok with that. It makes our choice between alternative
functions clearer, which is important in security-critical code.)
Let's get this merged, then close this ticket.
https://trac.torproject.org/projects/tor/attachment/ticket/7419/memset_s_explicit_bzero.diff
(I've split off #17986 for using SecureZeroMemory on Windows.)
(Removing nickm-patch because the latest patch is not by nickm.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7419#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs