[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #16990 [Tor Browser]: Circuit visualizer stops working after some time
#16990: Circuit visualizer stops working after some time
-------------------------------------------------+-------------------------
Reporter: cypherpunks | Owner: tbb-
Type: defect | team
Priority: Medium | Status:
Component: Tor Browser | needs_review
Severity: Normal | Milestone:
Keywords: tbb-torbutton tbb-circuit-display | Version:
TorBrowserTeam201601R, tbb-5.5 | Resolution:
Parent ID: | Actual Points:
Sponsor: | Points:
-------------------------------------------------+-------------------------
Comment (by arthuredelstein):
Replying to [comment:14 cypherpunks]:
Thanks for the comments.
> Why {{{getSOCKSCredentialsForBrowser}}} returns 2 values as a single
string, "user:pass" i.e. "host:nonce"?
> That host can include a port which then results in "domain:port:nonce".
Afterwards there's a
While I don't think the host here will include a port, I agree it's safer
not to use a colon. So I have changed it to a "|" character.
> In any case I think it would be clearer to just return a structure not a
compound string from {{{getSOCKSCredentialsForBrowser}}}.
Agreed.
> Unrelated to that: the comment for {{{setupDisplay}}} says "Returns a
function..." but that's not true, it doesn't return anything. I guess
that's documentation bitrot.
Yes, fixing that.
Here's an additional "code cleanup" patch with these changes, on the same
branch:
âhttps://github.com/arthuredelstein/torbutton/commits/16990+1
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16990#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs