[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18022 [Tor bundles/installation]: start-tor-browser.desktop parameter passing broken on spaces

#18022: start-tor-browser.desktop parameter passing broken on spaces
--------------------------------------+------------------------------
 Reporter:  adrelanos                 |          Owner:  erinn
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Tor bundles/installation  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-5.5                   |  Actual Points:
Parent ID:                            |         Points:
  Sponsor:                            |
--------------------------------------+------------------------------
Changes (by cypherpunks):

 * status:  new => needs_review


Comment:

 Here goes a replacement "execdesktop" for consideration.

 Differences:
 - Better documented, including some error checking.
 - In the subshell used to get the value of "X-TorBrowser-ExecShell": a
 single fork+exec instead of four pipelined.
 - Actually execs, so that there's no useless shell lingering.
 - Tabs for indentation. Wraps at 80 columns.
 - No branching on number of arguments.
 - More elegant code, if I may say so myself.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18022#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs