[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18022 [Tor bundles/installation]: start-tor-browser.desktop parameter passing broken on spaces

#18022: start-tor-browser.desktop parameter passing broken on spaces
--------------------------------------+------------------------------
 Reporter:  adrelanos                 |          Owner:  erinn
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Tor bundles/installation  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201601R     |  Actual Points:
Parent ID:                            |         Points:
  Sponsor:                            |
--------------------------------------+------------------------------

Comment (by cypherpunks):

 Replying to [comment:10 cypherpunks]:
 > Replying to [comment:8 cypherpunks]:
 > howdy, fellow sedder
 > > - More elegant code, if I may say so myself.
 > elegance in shell script? ;)

 Well, if not elegance, at least some sanity and consistency. Look at the
 mess that is "start-tor-browser": was obviously hacked together by several
 people, with some of them clearly not understanding how to write bash
 script.

 > this is a tweaked version, slightly more .desktop-compliant

 I like it.

 gk: I had to change some stuff in "start-tor-browser" (the log path
 selection is, uhh, "cognitively challenged"). I might rewrite other parts
 as well if you are interested.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18022#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs