[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #14334 [Tor]: Bugs when registering guard status in connection_or_connect()
#14334: Bugs when registering guard status in connection_or_connect()
-------------------------------------------------+-------------------------
Reporter: asn | Owner: asn
Type: defect | Status:
Priority: Medium | assigned
Component: Tor | Milestone: Tor:
Severity: Normal | 0.2.8.x-final
Keywords: tor-guard, 027-triaged-1-in, | Version: Tor:
PostFreeze027 | 0.2.7
Parent ID: | Resolution:
Sponsor: SponsorU | Actual Points:
| Points: small
-------------------------------------------------+-------------------------
Changes (by asn):
* severity: => Normal
Comment:
Hmm, I wonder what the right fix is here.
Could we just remove this block of code entirely?
{{{
/* If the connection failed immediately, and we're using
* a proxy, our proxy is down. Don't blame the Tor server. */
if (conn->base_.proxy_state == PROXY_INFANT)
entry_guard_register_connect_status(conn->identity_digest,
0, 1, time(NULL));
}}}
After all, is there any chance that `connection_connect()` will fail
''immediately'' with `-1` due to the remote guard node being down? It
seems to me that if `connection_connect()` fails ''immediately'' then it's
probably some networking issue in the local machine and it shows nothing
about the state of the guard node.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14334#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs