Re: [tor-bugs] #21095 [Metrics/Onionoo]: Accept more values for the "order" parameter

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21095: Accept more values for the "order" parameter
-----------------------------+------------------------------
 Reporter:  lukechilds       |          Owner:  metrics-team
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-help     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by karsten):

 Very quick response before running off for a few hours:

  - Using constants for field names makes sense, though "ascending" and
 "descending" don't really belong there but rather in the `server` package.
 Still, starting such a `Fields` interface or enum in the `docs` package
 sound fine.
  - Separate comparator class makes sense, though I'm not sure whether it
 rather belongs in the `server` package than `docs`.
  - Changes like copyright updates or Java 7 changes should be done in
 separate commits and for the entire code base.

 Feel free to hack on this, and I'll review it later.  Or I can start
 making changes myself this afternoon and ask you to review them
 afterwards.  Up to you.  Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21095#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs