[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21159 [Core Tor/Tor]: Superfluous Include Statement

#21159: Superfluous Include Statement
----------------------------+---------------------
 Reporter:  BenjaminPollak  |          Owner:
     Type:  enhancement     |         Status:  new
 Priority:  Very Low        |      Milestone:
Component:  Core Tor/Tor    |        Version:
 Severity:  Trivial         |     Resolution:
 Keywords:                  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:                  |        Sponsor:
----------------------------+---------------------

Comment (by cypherpunks):

 Replying to [ticket:21159 BenjaminPollak]:
 > Would it be appropriate then, to delete line 4 of
 /src/test/test_bt_cl.c?

 No, because `orconfig.h` includes
 [https://www.gnu.org/software/libc/manual/html_node/Feature-Test-
 Macros.html feature test macros] which must be defined before including
 system header files.

 The other way around (as in removing the `orconfig.h` include from
 `util.h`) could be possible but you'd have to be sure every file that
 includes `util.h` has included `orconfig.h` before it. A quick grep shows
 59 inclusions of `util.h` which would all need to be checked. I'm not sure
 the amount of work justifies the benefits (if there are any).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21159#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs