Re: [tor-bugs] #21175 [Metrics/Metrics website]: Line breaks separate checkboxes from labels in userstats-bridge-transport.html

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21175: Line breaks separate checkboxes from labels in userstats-bridge-
transport.html
-------------------------------------+------------------------------
 Reporter:  dcf                      |          Owner:  metrics-team
     Type:  defect                   |         Status:  new
 Priority:  Medium                   |      Milestone:
Component:  Metrics/Metrics website  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------------
Description changed by dcf:

Old description:

> The checkboxes and labels wrap such that the checkbox sometimes is left
> at the end of a line, separated from its label:
>
> [[Image(transport-wrap.png)]]
>
> This is the way it's currently formatted in website/web/WEB-
> INF/graph.jsp:
> {{{
> <input type="checkbox" name="transport" value="${row[0]}"
> id="transport_${row[0]}"${row[1]}>
> <label class="checkbox-label" for="transport_${row[0]}">${row[2]}</label>
> }}}
>
> I did some experiments in the DOM editor and this fixes the problem and
> looks good with the current CSS (make `input` a child of `label` rather
> than use a `for` attribute):
> {{{
> <label class="checkbox-label">
>   <input type="checkbox" name="transport" value="${row[0]}"
> id="transport_${row[0]}"${row[1]}>
> </label>
> }}}
>
> (Actually, the percentile checkboxes already work that way:)
> {{{
> <label class="checkbox-label">
>   <input type="checkbox" name="n" value="${row[0]}"${row[1]}> ${row[0]}
> </label>
> }}}

New description:

 The checkboxes and labels wrap such that the checkbox sometimes is left at
 the end of a line, separated from its label:

 [[Image(transport-wrap.png)]]

 This is the way it's currently formatted in website/web/WEB-INF/graph.jsp:
 {{{
 <input type="checkbox" name="transport" value="${row[0]}"
 id="transport_${row[0]}"${row[1]}>
 <label class="checkbox-label" for="transport_${row[0]}">${row[2]}</label>
 }}}

 I did some experiments in the DOM editor and this fixes the problem and
 looks good with the current CSS (make `input` a child of `label` rather
 than use a `for` attribute):
 {{{
 <label class="checkbox-label">
   <input type="checkbox" name="transport" value="${row[0]}"
 id="transport_${row[0]}"${row[1]}> ${row[2]}
 </label>
 }}}

 (Actually, the percentile checkboxes already work that way:)
 {{{
 <label class="checkbox-label">
   <input type="checkbox" name="n" value="${row[0]}"${row[1]}> ${row[0]}
 </label>
 }}}

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21175#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs