[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20981 [Applications/Tor Browser]: The localized date string on Windows reveals local time

#20981: The localized date string on Windows reveals local time
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-fingerinting, tbb-regression,    |  Actual Points:
  tbb-6.0-issues, TorBrowserTeam201701R          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:9 mcs]:
 > r=mcs
 >
 > I did not test the patch, but it looks plausible.
 > And I guess it is okay to return malloc'd memory since that is done in
 other cases. Your patch might be a couple of lines shorter if you used
 uprv_strdup(), but that is not a big deal.

 Thanks for reviewing it. That's a good suggestion. I've written a new
 patch using uprv_strdup and I will post it here later today once I am done
 testing.

 I believe the malloc'd memory is necessary -- later code attempts to free
 it if I recall correctly.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20981#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs