Re: [tor-bugs] #20168 [Core Tor/Tor]: Clarify our #if{n}def by commenting what they are at the #elif/#else/#endif

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20168: Clarify our #if{n}def by commenting what they are at the #elif/#else/#endif
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  cjb
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very Low                             |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Trivial                              |     Resolution:
 Keywords:  easy, lorax, nickm-                  |  Actual Points:
  deferred-20161005, review-group-15             |
Parent ID:                                       |         Points:
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * milestone:  Tor: 0.3.0.x-final => Tor: 0.3.1.x-final


Comment:

 Yeah I can see in the patch:

 {{{
 #endif /* defined(HAVE_MLOCKALL) && HAVE_DECL_MLOCKALL &&
 defined(RLIMIT_MEMLOCK) */
 }}}

 Ideally, we don't want those "defined()" in there... Apart from that, the
 changes looks good so I'm deferring this to 031 but if by 030 stable we
 have a new patch version fixing the above, let's consider it! This is just
 comment change.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20168#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs