[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21108 [Core Tor/Tor]: Dir auths should vote BadExit even if they don't vote Running
#21108: Dir auths should vote BadExit even if they don't vote Running
--------------------------+------------------------------------
Reporter: arma | Owner: nickm
Type: defect | Status: merge_ready
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version: Tor: 0.3.0.1-alpha
Severity: Normal | Resolution:
Keywords: 029-backport | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Changes (by arma):
* status: needs_review => merge_ready
Comment:
bug21108_029 looks fine to merge.
I think it could go into 030, since it isn't super critical to get it into
029.
I also think it isn't obviously the fix for this bug, since in my
description I said moria1 was voting for V2Dir, and the code in your patch
sets rs->is_v2_dir to 0, right? Oh wait, no, the code you're fixing used
to skip setting is_v2_dir to 0, and your patch now does set it to 0.
Perfect -- it sounds like this could indeed be the bug!
In that case, can we add a comment in there, about how we are explicitly
choosing not to reset is_bad_exit to 0? Especially with the /* FFFF */
right below it about how we should be careful not to forget new flags.
Actually, even better, I'll do it: {{{bug21108}}} in my arma. (I cherry-
picked your commit onto master first, so now it's in 030-land. Feel free
to move around as you think best.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21108#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs