[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24726 [Core Tor/Fallback Scripts]: Make sure a comma never appears anywhere in a fallback entry

#24726: Make sure a comma never appears anywhere in a fallback entry
---------------------------------------+-----------------------------------
 Reporter:  teor                       |          Owner:  teor
     Type:  enhancement                |         Status:  merge_ready
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.3.x-final
Component:  Core Tor/Fallback Scripts  |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  fallback, review-group-28  |  Actual Points:  0.1
Parent ID:  #22271                     |         Points:  0.1
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------------------
Changes (by pastly):

 * status:  needs_review => merge_ready


Comment:

 Commas are in fact removed Tested by adding `as,df` to all nicknames and
 verifying output nicknames only had `asdf` added. Also visually checked
 code that all `%s` formatters in the fallback entry code had a call to
 `cleanse_c_string`.

 LGTM, but make sure all `fallback-format-2-v4` are merge_ready.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24726#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs