[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22983 [Metrics/Library]: Add a Descriptor subinterface and implementation for Tor web server logs
#22983: Add a Descriptor subinterface and implementation for Tor web server logs
-----------------------------+-----------------------------------
Reporter: iwakeh | Owner: metrics-team
Type: enhancement | Status: needs_review
Priority: High | Milestone: metrics-lib 2.2.0
Component: Metrics/Library | Version:
Severity: Normal | Resolution:
Keywords: metrics-2018 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+-----------------------------------
Comment (by karsten):
I started looking at your branch, but it's a pretty big diff again, so
that'll take some time.
Regarding Git history, we're going to squash all these commits (except for
unrelated ones like adding a space or package-info) into a single commit
that adds interfaces, implementations, and tests, right? I'm asking,
because you marked some commits as "fixup!", but not all of them. Or do
you have a separation in mind? If so, which?
By the way, what was the reason for rebasing your branch? It would have
been a tad bit easier to stay on the same branch until we're done with the
review process. Just saying for future reviews.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22983#comment:56>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs