Re: [tor-bugs] #23881 [Core Tor/Tor]: Implement a way to utilise tor's logging system from Rust code

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23881: Implement a way to utilise tor's logging system from Rust code
-----------------------------------------------+---------------------------
 Reporter:  isis                               |          Owner:
                                               |  chelseakomlo
     Type:  enhancement                        |         Status:
                                               |  needs_revision
 Priority:  High                               |      Milestone:  Tor:
                                               |  0.3.3.x-final
Component:  Core Tor/Tor                       |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  rust, rust-pilot, review-group-28  |  Actual Points:
Parent ID:                                     |         Points:  3
 Reviewer:  nickm                              |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Newbie questions from oniongit that I can remember:
   * Does CString::new() do a complete copy on the message?
   * What part of the Rust code removes the indentation on the log strings?

 Change requests I can remember from oniongit:
   * The `tor_log_msg!()` macro documentation should document its support
 for `format!` syntax.
   * In C, all identifiers that start with an underscore are reserved: we
 can create constants like `LOG_WARN_`, but using `_LOG_WARN` is risky and
 we try not to do that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23881#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs