[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24584 [Core Tor/Tor]: Fix memory-leaked event_base_once() users.

#24584: Fix memory-leaked event_base_once() users.
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  merge_ready
 Priority:  Medium           |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-28  |  Actual Points:
Parent ID:  #23847           |         Points:
 Reviewer:  dgoulet          |        Sponsor:
-----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 * For the beauty of well formed C files and to address any OCD issues some
 developers may have, I would add a new line after so it also matches the
 `shutdown_did_not_work_event` syntax. :)

 {{{
 /** Event to run initialize_periodic_events_cb */
 static struct event *initialize_periodic_events_event = NULL;
 }}}

 rest lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24584#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs