[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #24906 [Core Tor/Tor]: Make channelpadding_update_padding_for_channel() use !channel_is_client()

#24906: Make channelpadding_update_padding_for_channel() use !channel_is_client()
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core     |    Version:  Tor: 0.3.1.1-alpha
  Tor/Tor                |
     Severity:  Normal   |   Keywords:  refactor, redundant, technical-debt
Actual Points:           |  Parent ID:  #23423
       Points:  0.5      |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 Because we need to include all relays, even if they are flapping in   the
 consensus:

 {{{
   // We should not allow malicious relays to disable or reduce padding for
   // us as clients. In fact, we should only accept this cell at all if
 we're
   // operating as a relay. Bridges should not accept it from relays,
 either
   // (only from their clients).
   if ((get_options()->BridgeRelay &&
        connection_or_digest_is_known_relay(chan->identity_digest)) ||
       !get_options()->ORPort_set) {
 }}}

 We should also use !server_mode() rather than !ORPort_set.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24906>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs