[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24898 [Core Tor/Tor]: We have two conflicting notions of channel_is_client()
#24898: We have two conflicting notions of channel_is_client()
-------------------------------------------------+-------------------------
Reporter: arma | Owner: (none)
Type: defect | Status:
| merge_ready
Priority: Medium | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.1.1-alpha
Severity: Normal | Resolution:
Keywords: tor-relay, 032-backport, | Actual Points:
031-backport, 030-backport-maybe-with-21406, |
029-backport-maybe-with-21406, review- |
group-30 |
Parent ID: | Points: 0.5
Reviewer: teor | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
Replying to [comment:12 nickm]:
> Will this cause warnings on the real network too?
>
> Why (did we introduce the create-cell check in the first place? ISTR
that we thought we had a reason to do so. It looks like Mike introduced
it in b0e92634d85a3bf7612a6ce0339b96e4aad1e0bb, and moved it in
02a5835c27780e45f705fc1c044b9c471b929dbe. Adding mike to cc.
Mike's comments say that it led to chutney failures.
I haven't observed any failures, but I have observed warnings in 0.3.2.9
when we apply this patch to master in a mixed network.
That really is a bug in 0.3.1 and 0.3.2, because Mike's 0.3.1 fix is
identifying clients incorrectly.
There's nothing we can do about these warnings, except backport the fix.
> We could skip the 0.3.0 backport, I think, since 0.3.0 is EOL at the end
of this month. But we should do an 0.2.9 backport if we think this is
important: 0.2.9 is supported till 2020.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24898#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs