[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #24927 [Core Tor/Tor]: if (n_chan_id) in circuit_build_failed() can't fail

#24927: if (n_chan_id) in circuit_build_failed() can't fail
------------------------------+--------------------------------
     Reporter:  arma          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core Tor/Tor  |    Version:  Tor: 0.2.4.4-alpha
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In circuit_build_failed() we have
 {{{
     const char *n_chan_id = circ->cpath->extend_info->identity_digest;
 [...]
     if (n_chan_id && !already_marked) {
 }}}

 But extend_info->identity_digest is
 {{{
   char identity_digest[DIGEST_LEN];
 }}}
 So n_chan_id is never going to be NULL.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24927>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs