[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24588 [Core Tor/Tor]: Make signal handlers optional, for starting Tor in-process
#24588: Make signal handlers optional, for starting Tor in-process
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-mobile, s8-api, review-group-30 | Actual Points:
Parent ID: #23684 | Points:
Reviewer: | Sponsor:
| Sponsor8
-------------------------------------------------+-------------------------
Comment (by mikeperry):
Ok, this documentation for the code looks great. I still think it is
surprising to list things in controller-spec.txt that can't be set via
SETCONF. The first paragraph of that section says "These options can be
set and examined by the SETCONF and GETCONF commands.."
How about this fixup so that it is not as much of a surprise:
https://gitweb.torproject.org/user/mikeperry/torspec.git/commit/?h=disable_signal_handlers&id=0d95894f3ae46009d0e3f5dddcbe3f221d8a6f1e
That branch also has a bonus commit for __OwningControllerFD:
https://gitweb.torproject.org/user/mikeperry/torspec.git/commit/?h=disable_signal_handlers&id=cde44d7276bef1ec4c538b5f585317c4a1ddeca5
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24588#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs