[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed
#20218: Fix and refactor and redocument routerstatus_has_changed
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: (none)
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: ipv6, 029-proposed, tor-control, | Actual Points: 0.5
easy, spec-conformance |
Parent ID: | Points: .1
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: needs_revision => needs_review
* actualpoints: => 0.5
Comment:
This looks fine to me, but it needs a review, and a changes file. It might
also help if it had unit tests.
A question for the team:
How can we make sure we update functions when we add new members to a
struct?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20218#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs