[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25094 [Core Tor/Tor]: 24902 fix breaks on clang

#25094: 24902 fix breaks on clang
--------------------------+------------------------------------
 Reporter:  catalyst      |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #24902        |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_review
 * milestone:  Tor: 0.2.9.x-final => Tor: 0.3.3.x-final


Comment:

 Let's target master with this ticket, and do the backport in #24902.

 Also, the round here is redundant and can be removed:
 {{{
 src/test/test_dos.c:179:19: error: implicit conversion loses integer
 precision:
       'long' to 'int' [-Werror,-Wshorten-64-to-32]
   int circ_rate = tor_lround(get_circuit_rate_per_second());
       ~~~~~~~~~   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 }}}

 See my branch bug25094 for fixes to clang errors, including better
 overflow checks in cc_stats_refill_bucket, and some more unit tests.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25094#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs