[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25094 [Core Tor/Tor]: 24902 fix breaks on clang
#25094: 24902 fix breaks on clang
--------------------------+------------------------------------
Reporter: catalyst | Owner: (none)
Type: defect | Status: merge_ready
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-dos | Actual Points: 0.2
Parent ID: #24902 | Points: 0.2
Reviewer: | Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):
* keywords: => tor-dos
* status: needs_review => merge_ready
Comment:
I've taken teor patch and fixed very minor thing (mostly syntax) and made
the `circuit_rate` to be a `uint64_t` instead of casting it. The getter
returns the `uin32_t` value so we are good in conversion there. Just one
less cast.
I've re-arranged the commit to have 3 of them, (1) teor's test fix, (2)
refill over/underflow checks, (3) add unit tests.
gcc and clang seems happy here.
Commits are in branch: `ticket24902_029_05` so it is easy for nick to
merge it forward into master. Let me know if you want me to move them to
the _033_02 branch or just plain latest master.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25094#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs