[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24469 [Core Tor/Tor]: Cannibalizing a circuit should check that first hop is in our guard state
#24469: Cannibalizing a circuit should check that first hop is in our guard state
--------------------------+------------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-circuit | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):
* status: accepted => needs_review
Comment:
Thanks to nickm, I've added a function in `entrynodes.c` to learn if a
circuit guard state is likely to succeed.
As much as I would like a unit test here, there seems to be _no_ existing
tests for cannibalizing circuits... Which is kind of worrying in some ways
but also makes it very tedious for this bug to get fixed. Might be time
for a ticket to get those and make it a big high prio? Or we think that
patch just can't go in without unit tests?
Both `circuit_launch_by_extend_info()` and `circuit_find_to_cannibalize()`
appears untested in our test suites.
See branch: `bug24469_033_01`
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24469#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs