[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28995 [Core Tor/Tor]: Fix the IPv6 case of tor_ersatz_socketpair

#28995: Fix the IPv6 case of tor_ersatz_socketpair
---------------------------+------------------------------------
 Reporter:  kjak           |          Owner:  (none)
     Type:  defect         |         Status:  needs_review
 Priority:  Medium         |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor   |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  035-backport?  |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------------
Changes (by nickm):

 * keywords:   => 035-backport?
 * milestone:   => Tor: 0.4.0.x-final


Comment:

 Looks good, but it will need a changes file before we can merge it.  I can
 write one, or somebody else can add one: see
 doc/HACKING/CodingStandards.md, under the heading `How we log changes`.

 I wonder, is this worth backporting to 0.3.5, or should we just take it in
 0.4.0?  I don't think we actually _call_ this function with AF_INET6
 anywhere, so it might not be necessary to backport.  But maybe we should
 backport anyway, to avoid problems down the road if we decide to backport
 something else that starts using AF_INET6 here.

 If we're thinking of a backport, the patch should be based on maint-0.3.5
 instead of master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28995#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs