[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28058 [Core Tor/Tor]: Run shellcheck as part of "make check"

#28058: Run shellcheck as part of "make check"
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  rl1987
     Type:  enhancement     |         Status:  needs_revision
 Priority:  Medium          |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:  mikeperry       |        Sponsor:
----------------------------+------------------------------------
Changes (by mikeperry):

 * status:  merge_ready => needs_revision


Comment:

 Actually, you know what.. Can we fix the formatting in that makefile rule,
 and maybe comment that the command -v thing is checking for shellcheck
 before running it? The fact that Nick missed that is probably a sign this
 code is too dense right now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28058#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs