[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #29063 [Core Tor/Tor]: shellcheck: test_rebind.sh issues

#29063: shellcheck: test_rebind.sh issues
------------------------------+----------------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  technical-debt
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+----------------------------
 {{{

 In test_rebind.sh line 18:
 clean () { test -n "$tmpdir" && test -d "$tmpdir" && rm -rf "$tmpdir" ||
 :; }
                                                   ^-- SC2015: Note that A
 && B || C is not if-then-else. C may run when A is true.


 In test_rebind.sh line 21:
 tmpdir="`mktemp -d -t tor_rebind_test.XXXXXX`"
         ^-- SC2006: Use $(..) instead of legacy `..`.

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29063>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs