[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #29069 [Core Tor/Tor]: shellcheck: autogen.sh issues

#29069: shellcheck: autogen.sh issues
------------------------------+----------------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  technical-debt
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+----------------------------
 {{{

 In autogen.sh line 3:
 if [ -x "`which autoreconf 2>/dev/null`" ] ; then
          ^-- SC2006: Use $(..) instead of legacy `..`.
           ^-- SC2230: which is non-standard. Use builtin 'command -v'
 instead.


 In autogen.sh line 6:
   for i in $@; do
            ^-- SC2068: Double quote array expansions to avoid re-splitting
 elements.


 In autogen.sh line 14:
   exec autoreconf $opt
                   ^-- SC2086: Double quote to prevent globbing and word
 splitting.

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29069>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs