[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28837 [Core Tor/Tor]: Use openssl's SHA3 implementations when they are faster.

#28837: Use openssl's SHA3 implementations when they are faster.
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.4.9
 Severity:  Normal                               |     Resolution:
 Keywords:  android startup performance          |  Actual Points:
  controller                                     |
Parent ID:  #28481                               |         Points:  .3
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Mostly looks good. I left some comments on the pull request about some
 refactoring opportunities, and some minor things.

 I tried building this with openssl-1.1.1a that I built from source and
 `make check` passes, for what that's worth.

 It would be good to have a rebased branch build in Travis to confirm that
 the TEST_STEM failure is due to the likely known cause.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28837#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs