[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29035 [Applications/Tor Browser]: Post-YE campaign clean up
#29035: Post-YE campaign clean up
-------------------------------------------------+-------------------------
Reporter: pili | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Minor | Resolution:
Keywords: TorBrowserTeam201901R, | Actual Points:
GeorgKoppen201901 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* cc: sstevenson (removed)
* cc: stevenson, igt0 (added)
* keywords: TorBrowserTeam201901, GeorgKoppen201901 =>
TorBrowserTeam201901R, GeorgKoppen201901
* status: new => needs_review
Comment:
`bug_29035_v3` has the patches for review. There are essentially three
parts: 1) removing the donation banner related changes (commit
9b4c56f050a266bbcd04d6985ee46f9da612e0e7), 2) removing the newsletter
sign-up banner changes (8d3c6f996c943399a1505646eee14ce81868c0c8), and 3)
adding the code changes for the new sign-up message/link on desktop and
mobile (commit e73ff049acb16d410083c9cad64da678aab30294).
I made it so that the whole sign-up related text and icon are on a single
line on tablets, laptops, and desktops while on phones it has the three
lines as outlined in comment:10. I am fine adjusting that as needed or
making it more complex, like on a phone in landscape mode show the single
line, too. I am not a web developer, so I don't have that strong opinions
here.
A mobile bundle for testing can be found at:
https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-
android-armv7-multi-qa_29035.apk
https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-
android-armv7-multi-qa_29035.apk.asc
steph: #28145 is the ticket for the remaining links on `about:tor` should
be doable for the next release provided we are sure how this should look
like.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29035#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs