[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28698 [Core Tor/Tor]: When circuit times are fixed, they can't be "relaxed"

#28698: When circuit times are fixed, they can't be "relaxed"
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, log, intro, fast-fix,          |  Actual Points:
  040-proposed                                   |
Parent ID:                                       |         Points:  0.2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  easy, log, intro, fast-fix => easy, log, intro, fast-fix,
     040-proposed
 * status:  new => needs_revision
 * points:   => 0.2
 * milestone:  Tor: unspecified => Tor: 0.4.0.x-final


Comment:

 Replying to [comment:1 guigom]:
 > I've written a little patch to start working on this at
 https://github.com/JMGuisadoG/tor/tree/ticket28698
 > commit:
 https://github.com/JMGuisadoG/tor/commit/9ae8031ac57b6e741230b23c213f904f8d629d1f

 Thanks for this patch!

 > Not sure what to write down on the ChangeLog file but stated this as a
 minor bugfix. Hope everything is ok, as this is my first contribution I'm
 expecting things will have to be changed a little.

 Your changes file looks good.

 Here's how we write changes files:
 https://github.com/torproject/tor/blob/master/doc/HACKING/CodingStandards.md
 #how-we-log-changes

 Your patch looks good, but we also need to disable the other log message
 here:
 https://github.com/JMGuisadoG/tor/commit/9ae8031ac57b6e741230b23c213f904f8d629d1f
 #diff-4f24e2b0a904b912701ad3d1efe53485R631

 If you open a pull request at https://github.com/torproject/tor , our CI
 will run on your patch. Then you can see any errors on platforms you don't
 have.

 Notes for the team: We can review this bugfix for 0.4.0. There's no need
 to discuss it at the team meeting.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28698#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs