[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25417 [Core Tor/Tor]: HSFETCH support for v3 Hidden Services

#25417: HSFETCH support for v3 Hidden Services
-------------------------------------------------+-------------------------
 Reporter:  atagar                               |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-control, tor-hs, prop224-extra,  |  Actual Points:
  onionbalance, 041-proposed                     |
Parent ID:  #28841                               |         Points:  0.5
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:20 neel]:
 > I have made the corrections.
 >
 > However, the statement you made in the GitHub torspec PR comments:
 >
 > > Controller app need to assert that something prefixed with v2- then 16
 chars are expected, not 56.
 >
 > I believe things prefixed with `v2-` are descriptor IDs and those are 32
 bytes long.
 >
 > Update: Never mind, the `v2-` is different from the HSAddress. I pushed
 the respective changes to my torspec PR.

 True, my mistake.

 I think you missed that comment?
 https://github.com/torproject/tor/pull/646#discussion_r250312545

 Also, `SERVER=` can be specified more than once so it is very important to
 follow what v2 does that is a list of HSDirs, not just an rs node.

 So basically, we need the entry point to be within `hs_control.h` API, and
 then calls the new function you added (hs client) but that one should take
 a list of HSDirs. Having the closest to the v2 behavior is desirable here
 and not much complexity added.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25417#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs