[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32747 [Metrics/CollecTor]: Avoid reprocessing webstats files

#32747: Avoid reprocessing webstats files
-------------------------------+------------------------------
 Reporter:  karsten            |          Owner:  karsten
     Type:  defect             |         Status:  needs_review
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:2 irl]:
 > The metrics-base commit is ok.
 >
 > The tests look good.

 Great! I'll merge these when the other commit looks good, too.

 > Why have you removed WebServerAccessLogPersistence to duplicate the code
 now in collector/webstats/SanitizeWeblogs.java?
 WebServerAccessLogPersistence is still used by the sync code so we get two
 versions of the same thing both in use.

 The reason was that we now have to calculate the output path of a web
 server access log ''before'' sanitizing, and it seemed easier to just pull
 the rest of the path-computing logic over from the persistence class. But
 I see your point about having this code in two places now.

 I took an alternative approach by adding another constructor to the
 persistence class that we can use when we don't have a sanitized web
 server access log yet. Please review
 [https://gitweb.torproject.org/user/karsten/collector.git/commit/?h=task-32747&id=94b87099197890c1614b301a3c493f47c8003f02
 squash commit 94b8709] when you get the chance. And please also review
 [https://gitweb.torproject.org/user/karsten/collector.git/commit/?h=task-32747&id=76db49572f55b4058f9d8c29f983a007f159dd4e
 squash commit 76db495] which fixes a minor bug that I found while testing
 today. Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32747#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs