[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32962 [Core Tor/Tor]: add_c_file: bug when adding to end of include.am

#32962: add_c_file: bug when adding to end of include.am
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  043-should    |  Actual Points:  .3
Parent ID:                |         Points:  .1
 Reviewer:  catalyst      |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  merge_ready => needs_review
 * actualpoints:  .1 => .3


Comment:

 Replying to [comment:3 catalyst]:
 > Replying to [comment:2 nickm]:
 > > I've got a patch for these at `ticket32962` with PR at
 https://github.com/torproject/tor/pull/1665
 > Thanks! Looks good.
 >
 > Nit: maybe we could use `os.path.relpath()` for consistency with
 `topdir_file()`?

 I found the path handling in this script really hard to understand. So I
 created a PR that distinguishes `tor`-relative (topdir, renamed to tordir)
 and `tor/src`-relative (srcdir) paths. I also made the canonicalisation
 more reliable.

 What do you think?
 * master: https://github.com/torproject/tor/pull/1667

 I had to rebase to avoid conflicts with the include.am split from #32137.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32962#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs