[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32979 [Applications/Tor Browser]: `make clean` fails with missing package not mentioned in README
#32979: `make clean` fails with missing package not mentioned in README
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam202001R, | Actual Points:
GeorgKoppen202001 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by boklm):
Replying to [comment:2 gk]:
> `bug_32979` (https://gitweb.torproject.org/user/gk/tor-browser-
build.git/commit/?h=bug_32979&id=b13a6010cd7ab59839c2a9a11c483c678cb9847e)
has the small fix up for review
There are two other places where we should add it:
- in the list of perl modules to install in the README file (for those not
using Debian)
- in the list of packages in `tools/ansible/roles/tbb-
builder/tasks/main.yml`
I have a patch in my branch `bug_32979_v2` doing that:
https://gitweb.torproject.org/user/boklm/tor-browser-
build.git/commit/?h=bug_32979_v2&id=14bb4de90418ce84b8bf603e0f7392c0a08dfbd1
After looking at git lgos, it seems we had it in the README in the past,
but removed it with #24361 (when rbm switched to `Path::Tiny` instead of
`File::Slurp`).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32979#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs