[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32435 [Applications/Tor Browser]: Compile clang for Linux x86_64 with WASM support
#32435: Compile clang for Linux x86_64 with WASM support
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-security, GeorgKoppen202001, | Actual Points:
TorBrowserTeam202001R |
Parent ID: #32434 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by boklm):
Replying to [comment:6 gk]:
> Replying to [comment:5 boklm]:
> > Replying to [comment:4 gk]:
> > > `bug_32389` (https://gitweb.torproject.org/user/gk/tor-browser-
build.git/commit/?h=bug_32389&id=298b18f9e1319077e8909b5ec43f270fbfabf405)
has a build patch up for review.
> >
> > One small simplification: I think the line `rlbox: '[%
c("var/nightly") && c("var/linux-x86_64") %]'` can be moved to `targets
/linux-x86_64` instead of `targets/linux`, so that the part `&& c("var
/linux-x86_64")` can be removed.
> > We can also remove the lines `rlbox: 0` for the other platforms, as it
is disabled by default.
>
> Done on `bug_32389_v2` (https://gitweb.torproject.org/user/gk/tor-
browser-
build.git/commit/?h=bug_32389_v2&id=a1eab9035af5b5d6cc8ab21615676f9f237c074f).
>
> I thought it would make it easier to clarify that the feature actually
is disabled on other platforms/architectures, in particular as we e.g. set
the snowflake part for Android to `0` explicitly, but fine with me. Should
I file a ticket to correct that (and the `namecoin: 0` ones)?
When I want to see if a feature is enabled/disable I usually look at all
the lines setting the option, so I find it better to have less lines to
look at. An exception would be if we also want to add a comment explaining
why it is disabled in such case (but that does not seem to be the case
here).
So I would also remove the snowflake and namecoin lines that are not
needed.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32435#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs