[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31482 [Core Tor/Tor]: Avoid possible overflow when converting between coarse stamp to approx ms

#31482: Avoid possible overflow when converting between coarse stamp to approx ms
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.4.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  043-should, 035-backport,            |  Actual Points:  0.5
  040-backport, 041-backport, 042-backport,      |
  security? 043-should?                          |
Parent ID:                                       |         Points:  1
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * owner:  teor => (none)
 * status:  needs_revision => assigned


Comment:

 Here's what I've done so far:
 * 0.3.5: https://github.com/torproject/tor/pull/1435

 Here's the incomplete work:
 * Fix macOS unit test error
 * tests for monotime_coarse_stamp_units_to_approx_msec() and
 monotime_msec_to_approx_coarse_stamp_units()
   * more values
   * precise and approximate cases, and their boundary conditions
   * underflow and overflow (close to 2^30^ ?)

 Here's what still needs to be done:
 * do a GCD calculation on Windows init
 * refactor and extra tests for monotime_init_internal()
 * changes file

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31482#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs