[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33039 [Core Tor/Tor]: Memory leaks in handle_control_getconf
#33039: Memory leaks in handle_control_getconf
-------------------------------------------------+-------------------------
Reporter: nickm | Owner:
| catalyst
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 043-must, memory-leak, regression, | Actual Points: 2
tor-tests-coverage |
Parent ID: | Points: 1
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):
* status: accepted => needs_review
* actualpoints: => 2
Comment:
Pull request in https://github.com/torproject/tor/pull/1684
As a bonus, unit test coverage in `handle_control_getconf()` is now at
100%.
I did confirm that the new unit tests correctly detect the leak under
valgrind on Ubuntu Bionic. (valgrind doesn't work with OpenSSL on Xenial,
so I had to install a new VM.) For some reason, AddressSanitizer doesn't
catch the leaks in tor itself, but does catch them in the test program.
(Both Xenial and Bionic, and I think both clang and gcc.) I wish we could
understand why.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33039#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs