Re: [tor-bugs] #32230 [Core Tor/Tor]: configure summary is confusing or incorrect

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#32230: configure summary is confusing or incorrect
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  dgoulet
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:  043-must      |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  assigned => needs_review
 * reviewer:   => teor


Comment:

 Replying to [ticket:32230 teor]:
 > Some of the options in the new configure summary are confusing or
 incorrect. The configure summary was introduced in #31373.
 >
 > Wrong place:
 > * maybe --enable-systemd should be an optional library?

 Agree.

 >
 > Inverted, should be --enable-* :
 > * --disable-seccomp
 > * --disable-libscrypt
 > * --disable-gcc-hardening ?
 > * --disable-linker-hardening ?
 > * --disable-module-dirauth
 > * --disable-unittests

 All these are enabled by default and thus why we put in the `--disable`.
 If one does autocompletion on `./configure --enable-`, none of the above
 shows up.

 >
 > Remove Double-Negative ? :
 > * assert()s disabled (--disable-asserts-in-tests, dev only):     no
 >   * assert()s enabled (--enable-asserts-in-tests, dev only):     yes

 Agree.

 > Broken:
 > * --enable-gcc-warnings:
 >   * is not Verbose Warnings
 >   * is an alias for --enable-fatal-warnings, which is already listed
 >   * did you mean --disable-gcc-warnings-advisory ?

 I did not realize it was an alias and it is deprecated. I will remove it.

 > * --disable-asciidoc
 >   * also disables manpages and HTML, but they are shown as enabled

 Added!

 > * --enable-fragile-hardening
 >   * should be true if --enable-expensive-hardening is set, but is shown
 as false

 Fixed.

 >
 > Missing:
 > * --disable-module-relay

 That one is there.

 >   * please build the module feature summary from the list of modules in
 configure

 Done.

 > * --disable-asciidoc

 Fixed.

 > * --enable-lzma
 > * --enable-zstd
 > * --enable-cargo-online-mode

 Added the above.

 > * --with-tor-user=[user]
 > * --with-tor-group=[group]

 I have no clue where this is used. I can't find `TORUSER` or `TORGROUP`
 being used anywhere?

 > * and a few others
 > * and a whole bunch of env vars

 For now this is a good improvement! We can add the rest as we notice them.

 Branch: `ticket32230_043_01`
 PR: https://github.com/torproject/tor/pull/1701

 (Putting teor as a reviewer in order to confirm if this is acceptable from
 their original post).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32230#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs