[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #1688 [Tor - Distribution]: tordnsel 0.0.6 does not compile on GHC6.8.

#1688: tordnsel 0.0.6 does not compile on GHC6.8.
----------------------+-----------------------------------------------------
 Reporter:  nejucomo  |        Type:  defect              
   Status:  new       |    Priority:  normal              
Milestone:            |   Component:  Tor - Distribution  
  Version:            |    Keywords:  tordnsel ghc haskell
   Parent:            |  
----------------------+-----------------------------------------------------
 GHC changed various compiler flag requirements as well as APIs between
 ghc6.6 and ghc6.8.

 This patch allows tordnsel to compile against ghc6.8 (which is on lenny).

 This patch deserves security review.  I'm not certain what implications
 the compiler flags have.

 The most dubious change is using "unsafePerformIO .
 Data.ByteString.Unsafe.unsafePackAddress" which could conceivably
 introduce buffer overflow issues.  I have a feeling this is not likely as
 long as unsafePackAddress is idempotent (in which case the order of side
 effects hopefully does not matter).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1688>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online