[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] Re: #1320 [Tor - Tor client]: Tor/Vidalia report wrong hostname on same IP
#1320: Tor/Vidalia report wrong hostname on same IP
----------------------+-----------------------------------------------------
Reporter: downie | Type: defect
Status: new | Priority: minor
Milestone: | Component: Tor - Tor client
Version: 0.2.1.24 | Resolution: None
Keywords: | Parent:
----------------------+-----------------------------------------------------
Comment(by mwenge):
Replying to [comment:6 edmanm]:
> If a stream event includes only an IP address, Vidalia will use the
`address-mappings` command to try to find the previous host name for that
IP address. If two hostnames map to the same IP address, Vidalia has no
way of knowing which one is correct given only the IP address. One
alternative is to simply display the IP address for such cases, but then
user would probably complaint that they're seeing an IP address rather
than a (possibly incorrect) hostname.
I think the problem is that a new Stream object is instantiated from each
event and the target from that event is always used to update the stream
item. So Vidalia doesn't remember that in the first event for the stream
it got the correct hostname for the stream from Tor, i.e.:
650 STREAM 255 NEW 0 metrics.torproject.org:80 SOURCE_ADDR=127.0.0.1:38193
PURPOSE=USER
So when it later gets an event:
650 STREAM 256 SENTCONNECT 54 38.229.70.37:80
and reverse maps the IP it gets the first hit in its cache for that
address rather than the hostname actually associated with stream.
Should vidalia only update the target in the StreamItem if it does not
already have an opinion on the target's hostname (e.g. through maintaing a
map of streams/hostnames)?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1320#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online