[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2798 [Tor Client]: Special-case country codes and address set patterns in EntryNodes

#2798: Special-case country codes and address set patterns in EntryNodes
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 It looks like entry_guards_prepend_from_config() no longer prepends from
 config? It might want a name change then. I guess its new behavior is more
 like 'append' than 'prepend'.

 I'd call this a major bugfix, since in 0.2.3.1 we did some pretty
 dangerous things to your entry guard behavior if you set entrynodes {de}.

 The 'entry_routers' term remains in the comment even though the variable
 has been renamed for a while.

 s/reset/rest/

 {{{
    smartlist_clear(entry_guards);
    /* First, the previously configured guards that are in EntryNodes. */
    smartlist_add_all(entry_guards, old_entry_guards_on_list);
 +  /* Next, scramble the reset of EntryNodes, putting the guards first. */
 +  smartlist_shuffle(entry_nodes);
 }}}

 So it looks like we're reordering the list of guards every time we get a
 new consensus? It might be smarter to leave the previous set in order.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2798#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs