[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1666 [Tor Client]: SOCKS handling should accept (and ignore) password auth.

#1666: SOCKS handling should accept (and ignore) password auth.
-------------------------+--------------------------------------------------
 Reporter:  nickm        |          Owner:  mwenge            
     Type:  enhancement  |         Status:  needs_review      
 Priority:  normal       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client   |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by ln5):

 My brain is clearly not built for grokking logic like the one in
 parse_socks().  :-(

 What with situations like req->socks_version == 5 && req->got_auth?  Can
 it happen and what can data point at?  Or rather, what values are possible
 for req->socks_version and req->got_auth when data points at anything
 which is _not_ the start of a socks message?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1666#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs